Skip to content

Quick Connect QR code for "Sign in with theweasel.tv" and the Jellyfin 12 fixes - #20

Merged
Weaseltv merged 3 commits into
weaselfinfrom
t3code/quick-connect-qr
Oct 1, 2026
Merged

Weaseltv merged 3 commits into
weaselfinfrom
t3code/quick-connect-qr

Conversation

@Weaseltv

@Weaseltv Weaseltv commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Phase 3.3 (and Phase 1 step 5) of the one sign-in plan (Notion: Implementation plan — one sign-in for theweasel.tv and WeaselPlex). Pairs with platform PR damontecres#134 (/weaselplex/connect approve page, merged).

What changed

  • QR code in the Quick Connect dialog (SwitchUserContent.kt, new QuickConnectQrCode.kt): when WeaselPlex hands back a code, the dialog shows a QR for https://theweasel.tv/weaselplex/connect?code=<code>&device=tv above the six digits, with the hint "Scan with your phone, or go to theweasel.tv/plex and enter the code". The phone signs in with the website account and approves the code; the TV keeps polling and signs in as before.
  • Poll every 2 s instead of 5 s (SwitchUserViewModel.kt) so an approved code lands promptly.
  • Flavor-gated: QUICK_CONNECT_APPROVE_URL / QUICK_CONNECT_APPROVE_LABEL build fields are blank in defaultConfig and set only in the weaselfin flavor, so upstream flavors keep the plain code dialog and rebases stay clean.
  • com.google.zxing:core 3.5.3 added (pure Java QR encoder, no camera dependency).
  • Jellyfin 12 cherry-picks from upstream (Phase 1 step 5): "Guard against crash if episode has seasonId but no seriesId (Guard against crash if episode has seasonId but no seriesId damontecres/Wholphin#1964)" and "Catch & display error during loading a series".

Checks

  • ./gradlew :app:compileWeaselfinDebugKotlin passes.
  • Not run here: a device install. The signed APK, the v1.2.5 tag and the theweasel.tv publish are owner-gated; the website side needs WEASELPLEX_PORTAL_ENABLED=true in production for the approve page to be live.

Owner review points

  • QR size (200 dp) and hint wording on the TV.
  • The dialog column stays at 40 % width; widen if the hint wraps awkwardly on your SHIELD.

🤖 Generated with Claude Code

damontecres and others added 3 commits September 30, 2026 22:40
…ntecres#1964)

## Description
When clicking on an episode, the app assumes if there is a season ID for
the episode, then there must be a series ID. However, on my JF 12.0
server, an episode (with no metadata) appeared on my Continue Watching
and it has a season ID (which in turn has a series ID) but no series ID.

I'm not sure if this really a valid situation or if it's a server bug,
but Wholphin shouldn't crash at least. So this PR checks both `seasonId`
and `seriesId` and if either is null, falls back to the generic "Episode
Page". Similarly, if a season has no `seriesId` (again, not sure if a
valid situation), a crash won't occur, however there is no generic
"Season Page", so an error page is shown.

### Related issues
TODO, check JF server issues, maybe fixed in 12.1?

### Testing
Emulator

## Screenshots
N/a

## AI or LLM usage
None
WeaselFin builds now carry QUICK_CONNECT_APPROVE_URL (the website's approve
page) and QUICK_CONNECT_APPROVE_LABEL (theweasel.tv/plex). When a Quick
Connect code arrives, the dialog shows a QR code for
<approve url>?code=<code>&device=tv above the six digits, with the hint
"Scan with your phone, or go to theweasel.tv/plex and enter the code". The
phone opens the page, signs in with the website account and approves the
code; the TV keeps polling as before, now every two seconds instead of five
so the sign-in lands promptly.

Upstream flavors leave both fields blank and keep the plain code dialog.
zxing-core (pure Java) renders the QR bitmap, black on white.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@Weaseltv
Weaseltv merged commit 6f9da4c into weaselfin Oct 1, 2026
2 checks passed
@Weaseltv
Weaseltv deleted the t3code/quick-connect-qr branch October 1, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants